Add analyze steps to iOS try bot builds which use ninja

scripts/slave/recipe_modules/ios/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import copy
+
 from slave import recipe_api
 
 
 class iOSApi(recipe_api.RecipeApi):
   def __init__(self, *args, **kwargs):
     super(iOSApi, self).__init__(*args, **kwargs)
     self.__config = None
 
   def host_info(self):
     """Emits information about the current host and available tools."""
@@ skipping 100 matching lines @@
       self.m.path['build'].join(
         'scripts',
         'slave',
         'ios',
         'find_xcode.py',
       ),
       '--json-file', self.m.json.output(),
       '--version', self.__config['xcode version'],
     ], step_test_data=lambda: self.m.json.test_api.output({}))
 
-  def build(self, official=False):
+    self.m.chromium.make_config().gyp_env.GYP_DEFINES = copy.deepcopy(

[Paweł Hajdan Jr., 2015/02/27 08:08:13]

Could you replace "make_config()" with "c"? We use the latter and I haven't seen
the former much.

Please let me know if this doesn't work, and then consider asking Robbie or
Aaron for the best solution. I'll be fine with any recommendation they make.

My specific concern here is whether make_config() creates a _temporary_ config
object, and so whether other modules are going to see this change. If the
current code works, "c" should also work and would be more consistent with other
code.

[smut, 2015/02/27 19:09:06]

Okay, I figured out the actual correct way to do this.

+      self.__config['GYP_DEFINES']
+    )
+
+  def build(self):
     """Builds from this bot's build config."""
     assert self.__config is not None
 
     # Add the default GYP_DEFINES.
     gyp_defines = [
       'component=static_library',
       'OS=ios',
     ]
 
     gyp_defines.extend(
@@ skipping 28 matching lines @@
           'device': 'iphoneos',
         }[self.platform])
       )
       cmd = ['ninja', '-C', cwd]
 
     step_result = self.m.gclient.runhooks(env=env)
     step_result.presentation.step_text = (
       '<br />GYP_DEFINES:<br />%s' % '<br />'.join(gyp_defines)
     )
 
+    if self.compiler == 'ninja' and self.m.tryserver.is_tryserver:
+      tests = [test['app'] for test in self.__config['tests']]
+      self.m.chromium_tests.analyze(tests, tests, 'trybot_analyze_config.json')
+
     self.m.step('compile', cmd, cwd=cwd)
 
   def test(self, *args):
     """Runs tests as instructed by this bot's build config.
 
     Args:
       *args: Any additional arguments to pass to the test harness.
     """
     assert self.__config is not None
     test_failures = []
@@ skipping 125 matching lines @@
         self.configuration,
         'iossim',
       ),
       'ninja': self.m.path.join(
         'src',
          build_dir,
          '%s-%s' % (self.configuration, platform),
          'iossim',
       ),
     }[self.compiler]