Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 957403004: Compile shader upon deletion if attached. (Closed)

Created:
5 years, 10 months ago by David Yen
Modified:
5 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Compile shader upon deletion if attached. R=kbr@chromium.org, vmiura@chromium.org BUG=459778 TEST=chromote locally with enableVideoDecodeRenderer Review URL: https://codereview.chromium.org/954073002 Cr-Commit-Position: refs/heads/master@{#317985} NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -16 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 4 chunks +20 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/gl_program_unittest.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
David Yen
merge to branch 2311, PTAL.
5 years, 10 months ago (2015-02-26 19:35:34 UTC) #1
David Yen
On 2015/02/26 19:35:34, David Yen wrote: > merge to branch 2311, PTAL. I'm not too ...
5 years, 10 months ago (2015-02-26 19:36:36 UTC) #4
Zhenyao Mo
On 2015/02/26 19:36:36, David Yen wrote: > On 2015/02/26 19:35:34, David Yen wrote: > > ...
5 years, 10 months ago (2015-02-26 19:43:03 UTC) #5
Ken Russell (switch to Gerrit)
On 2015/02/26 19:43:03, Zhenyao Mo wrote: > On 2015/02/26 19:36:36, David Yen wrote: > > ...
5 years, 10 months ago (2015-02-26 22:22:07 UTC) #6
Zhenyao Mo
LGTM
5 years, 10 months ago (2015-02-26 22:46:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957403004/1
5 years, 10 months ago (2015-02-26 22:48:46 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 22:50:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698