Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 957263002: Mixed Content: Explicitly allow blockable content for specific tests. (Closed)

Created:
5 years, 10 months ago by Mike West
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mixed Content: Explicitly allow blockable content for specific tests. In preparation for changing the default, we need to explicitly set the preference in tests which verify that exceptions work correctly. Patch 1: [THIS PATCH] Patch 2: Chromium: https://codereview.chromium.org/960853002 Patch 3: Blink: https://codereview.chromium.org/961633002/ BUG=462158 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M LayoutTests/http/tests/security/mixedContent/insecure-css-in-iframe.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-css-in-main-frame.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-css-resources.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-font-in-main-frame.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-iframe.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-iframe-in-main-frame.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-script-in-iframe.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html View 1 chunk +3 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
1/3 fairly trivial patches.
5 years, 10 months ago (2015-02-26 10:56:41 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-26 15:08:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957263002/1
5 years, 10 months ago (2015-02-26 15:46:45 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 15:49:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190925

Powered by Google App Engine
This is Rietveld 408576698