Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 960853002: Mixed Content: Block blockable mixed content by default in tests. (Closed)

Created:
5 years, 10 months ago by Mike West
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mixed Content: Block blockable mixed content by default in tests. This matches the behavior we're actually shipping. Patch 1: Blink: https://codereview.chromium.org/957263002/ Patch 2: [THIS PATCH] Patch 3: Blink: https://codereview.chromium.org/961633002/ BUG=462185 Committed: https://crrev.com/8f96214e622edfd092c54e3fa873bafce8faeab5 Cr-Commit-Position: refs/heads/master@{#318425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/common/webkit_test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
2/3.
5 years, 10 months ago (2015-02-26 10:56:54 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-26 15:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960853002/1
5 years, 9 months ago (2015-02-27 10:00:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 10:02:48 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 10:03:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f96214e622edfd092c54e3fa873bafce8faeab5
Cr-Commit-Position: refs/heads/master@{#318425}

Powered by Google App Engine
This is Rietveld 408576698