Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 957123002: Add missing printExtension to print settings for print preview (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing printExtension to print settings for print preview BUG=461888 Committed: https://crrev.com/32b8f25cacbefd083b54402e402e280dbe239063 Cr-Commit-Position: refs/heads/master@{#318852}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/browser/resources/print_preview/native_layer.js View 1 chunk +1 line, -0 lines 0 comments Download
M printing/printing_context.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
tbarzic
When you get a chance, can you test if this fixes the linked bug (it ...
5 years, 10 months ago (2015-02-25 23:56:57 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 9 months ago (2015-02-27 07:08:19 UTC) #4
Aleksey Shlyapnikov
lgtm
5 years, 9 months ago (2015-02-27 17:48:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957123002/20001
5 years, 9 months ago (2015-02-27 17:49:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tests_recipe/builds/6784)
5 years, 9 months ago (2015-02-27 18:53:59 UTC) #9
Vitaly Buka (NO REVIEWS)
On 2015/02/27 18:53:59, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-02-27 18:58:49 UTC) #10
Vitaly Buka (NO REVIEWS)
lgtm works on windows and osx
5 years, 9 months ago (2015-03-03 06:02:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957123002/20001
5 years, 9 months ago (2015-03-03 06:03:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 07:56:05 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 07:57:00 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32b8f25cacbefd083b54402e402e280dbe239063
Cr-Commit-Position: refs/heads/master@{#318852}

Powered by Google App Engine
This is Rietveld 408576698