Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: printing/printing_context.cc

Issue 957123002: Add missing printExtension to print settings for print preview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/native_layer.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context.cc
diff --git a/printing/printing_context.cc b/printing/printing_context.cc
index a589900610a5367444e21279dd9ce1278c224dc8..9748a17075cf72ff0e4d12c8bccc4163f93bb12f 100644
--- a/printing/printing_context.cc
+++ b/printing/printing_context.cc
@@ -63,6 +63,7 @@ PrintingContext::Result PrintingContext::UsePdfSettings() {
pdf_settings->SetBoolean(kSettingPrintToPDF, true);
pdf_settings->SetBoolean(kSettingCloudPrintDialog, false);
pdf_settings->SetBoolean(kSettingPrintWithPrivet, false);
+ pdf_settings->SetBoolean(kSettingPrintWithExtension, false);
return UpdatePrintSettings(*pdf_settings);
}
@@ -78,10 +79,13 @@ PrintingContext::Result PrintingContext::UpdatePrintSettings(
bool print_to_pdf = false;
bool is_cloud_dialog = false;
bool print_with_privet = false;
+ bool print_with_extension = false;
if (!job_settings.GetBoolean(kSettingPrintToPDF, &print_to_pdf) ||
!job_settings.GetBoolean(kSettingCloudPrintDialog, &is_cloud_dialog) ||
- !job_settings.GetBoolean(kSettingPrintWithPrivet, &print_with_privet)) {
+ !job_settings.GetBoolean(kSettingPrintWithPrivet, &print_with_privet) ||
+ !job_settings.GetBoolean(kSettingPrintWithExtension,
+ &print_with_extension)) {
NOTREACHED();
return OnError();
}
@@ -90,8 +94,9 @@ PrintingContext::Result PrintingContext::UpdatePrintSettings(
bool open_in_external_preview =
job_settings.HasKey(kSettingOpenPDFInPreview);
- if (!open_in_external_preview && (print_to_pdf || print_to_cloud ||
- is_cloud_dialog || print_with_privet)) {
+ if (!open_in_external_preview &&
+ (print_to_pdf || print_to_cloud || is_cloud_dialog || print_with_privet ||
+ print_with_extension)) {
settings_.set_dpi(kDefaultPdfDpi);
gfx::Size paper_size(GetPdfPaperSizeDeviceUnits());
if (!settings_.requested_media().size_microns.IsEmpty()) {
« no previous file with comments | « chrome/browser/resources/print_preview/native_layer.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698