Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 957113002: [Extensions] Record the extension function names which send a bad message. (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
Reviewers:
Yoyo Zhou, jwd
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Record the extension function names which send a bad message. BUG=462026 R=yoz@chromium.org Committed: https://crrev.com/ed0333227d728aada5d37a49e40b15240b5dbdef Cr-Commit-Position: refs/heads/master@{#318830}

Patch Set 1 #

Patch Set 2 : format somebody else's histogram... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -28 lines) Patch
M extensions/browser/extension_function.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_function_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_function_dispatcher.cc View 9 chunks +24 lines, -21 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
not at google - send to devlin
yoz - extensions. jwd - metrics.
5 years, 9 months ago (2015-02-25 23:42:40 UTC) #2
Yoyo Zhou
LGTM
5 years, 9 months ago (2015-02-25 23:52:59 UTC) #5
jwd
lgtm
5 years, 9 months ago (2015-03-02 16:17:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957113002/1
5 years, 9 months ago (2015-03-02 17:04:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/46618)
5 years, 9 months ago (2015-03-02 17:20:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/957113002/20001
5 years, 9 months ago (2015-03-03 01:53:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 03:27:06 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 03:28:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed0333227d728aada5d37a49e40b15240b5dbdef
Cr-Commit-Position: refs/heads/master@{#318830}

Powered by Google App Engine
This is Rietveld 408576698