extensions/browser/extension_function.cc - Issue 957113002: [Extensions] Record the extension function names which send a bad message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.cc

Issue 957113002: [Extensions] Record the extension function names which send a bad message. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format somebody else's histogram... Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/extension_function.cc

diff --git a/extensions/browser/extension_function.cc b/extensions/browser/extension_function.cc

index b970fe373bc1f33302652687f037a8a447bba218..6a136b2c0613e69988afe123429e42314fb864ee 100644

--- a/extensions/browser/extension_function.cc

+++ b/extensions/browser/extension_function.cc

@@ -404,7 +404,7 @@ void ExtensionFunction::SendResponseImpl(bool success) {

if (!results_)

results_.reset(new base::ListValue());

- response_callback_.Run(type, *results_, GetError());

+ response_callback_.Run(type, *results_, GetError(), histogram_value());

}

void ExtensionFunction::OnRespondingLater(ResponseValue value) {

« no previous file with comments | « extensions/browser/extension_function.h ('k') | extensions/browser/extension_function_dispatcher.h » ('j') | no next file with comments »