Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 956853005: Shorten up some site titles, also remove some trailing whitespace. (Closed)

Created:
5 years, 10 months ago by jcgregorio
Modified:
5 years, 10 months ago
Reviewers:
hal.canary, hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Shorten up some site titles, also remove some trailing whitespace. BUG=skia: Committed: https://skia.googlesource.com/skia/+/37a6107385ecb166b50588a9612e0e96acc0a898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -49 lines) Patch
M site/dev/chrome/blink.md View 3 chunks +40 lines, -38 lines 0 comments Download
M site/dev/chrome/changes.md View 3 chunks +6 lines, -6 lines 0 comments Download
M site/dev/chrome/index.md View 1 chunk +3 lines, -3 lines 0 comments Download
M site/dev/chrome/repo.md View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jcgregorio
5 years, 10 months ago (2015-02-25 17:54:38 UTC) #2
hcm
On 2015/02/25 17:54:38, jcgregorio wrote: LGTM like the shorter titles
5 years, 10 months ago (2015-02-25 18:01:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956853005/1
5 years, 10 months ago (2015-02-25 19:36:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/37a6107385ecb166b50588a9612e0e96acc0a898
5 years, 10 months ago (2015-02-25 19:49:19 UTC) #6
hal.canary
Are you sure note of that trailing whitespace was meaningful in Markdown? http://daringfireball.net/projects/markdown/syntax#p
5 years, 10 months ago (2015-02-25 21:43:55 UTC) #8
jcgregorio
5 years, 10 months ago (2015-02-25 22:11:19 UTC) #9
Message was sent while issue was closed. 
On 2015/02/25 21:43:55, Hal Canary wrote:
> Are you sure note of that trailing whitespace was meaningful in Markdown?
> http://daringfireball.net/projects/markdown/syntax#p

All the pages looked the same to me.

Also, If we did need a break within a paragraph I'd rather see <br/>'s in there
instead of trailing whitespace.

Powered by Google App Engine
This is Rietveld 408576698