site/dev/chrome/changes.md - Issue 956853005: Shorten up some site titles, also remove some trailing whitespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: site/dev/chrome/changes.md

Issue 956853005: Shorten up some site titles, also remove some trailing whitespace. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: site/dev/chrome/changes.md

diff --git a/site/dev/chrome/changes.md b/site/dev/chrome/changes.md

index 5ded65752c0fa8469946b058fc9d902dfd9e6490..af829b4ac9185dc2790ba633fe025cc9c5f75421 100644

--- a/site/dev/chrome/changes.md

+++ b/site/dev/chrome/changes.md

@@ -1,5 +1,5 @@

-Landing Skia changes which require associated Chrome changes

-============================================================

+Chrome changes

+==============

If your change modifies the Skia API, you may also need to land a change in Chromium.

@@ -9,12 +9,12 @@ recommend using build flag suppressions \(defines\)\.

We also prefer making the old code path opt-in where possible.

Method 1 \(preferred\) \- Make the old code path opt\-in for Chromium

* Add new code to Skia, leaving the old code in place.

* Deprecate the old code path so that it must be enabled with a flag such as

'SK_SUPPORT_LEGACY_XXX'.

* Synchronize the above changes in Skia with a Chromium commit to

- 'skia/skia_common.gypi' or 'skia/config/SkUserConfig.h' to enable the

+ 'skia/skia_common.gypi' or 'skia/config/SkUserConfig.h' to enable the

deprecated Skia API.

* Note that the code suppression cannot exist in both the header file and

the gyp file, it should only reside in one location.

@@ -25,10 +25,10 @@ Method 2 \- Make the new code path opt\-in for Chromium

* Add new code to Skia, suppressed by a flag.

* Leave the old code path in place.

- * Set the flag in Chromium's 'skia/skia_common.gypi' or

+ * Set the flag in Chromium's 'skia/skia_common.gypi' or

'skia/config/SkUserConfig.h' to enable the new or updated Skia API.

* Test the new or updated Skia API within Chromium.

- * Remove the code suppression \(and code\) when the legacy API is no longer

+ * Remove the code suppression \(and code\) when the legacy API is no longer

in use.

If your changes will affect Blink layout tests, see detailed instructions about

« no previous file with comments | « site/dev/chrome/blink.md ('k') | site/dev/chrome/index.md » ('j') | no next file with comments »