Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 956813002: Remove unused transparency display items. (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused transparency display items. With the brand new Compositing display items, we no longer need these transparency methods. This patch depends on a blink-side patch: https://codereview.chromium.org/953143003. Committed: https://crrev.com/1bb2b1f8842f408efdf295fb7202dbbaf447f943 Cr-Commit-Position: refs/heads/master@{#318152}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove transparency_display_item completely #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -166 lines) Patch
M cc/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_display_item_list_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 2 2 chunks +0 lines, -14 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D cc/resources/transparency_display_item.h View 1 1 chunk +0 lines, -66 lines 0 comments Download
D cc/resources/transparency_display_item.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pdr.
5 years, 10 months ago (2015-02-25 04:37:16 UTC) #2
ajuma
lgtm https://codereview.chromium.org/956813002/diff/1/cc/blink/web_display_item_list_impl.cc File cc/blink/web_display_item_list_impl.cc (left): https://codereview.chromium.org/956813002/diff/1/cc/blink/web_display_item_list_impl.cc#oldcode92 cc/blink/web_display_item_list_impl.cc:92: display_item_list_->AppendItem(cc::TransparencyDisplayItem::Create( I believe this is the only caller ...
5 years, 10 months ago (2015-02-25 14:16:01 UTC) #3
pdr.
On 2015/02/25 at 14:16:01, ajuma wrote: > lgtm > > https://codereview.chromium.org/956813002/diff/1/cc/blink/web_display_item_list_impl.cc > File cc/blink/web_display_item_list_impl.cc (left): ...
5 years, 10 months ago (2015-02-25 18:25:54 UTC) #4
ajuma
Thanks, lgtm!
5 years, 10 months ago (2015-02-25 18:27:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956813002/20001
5 years, 10 months ago (2015-02-25 22:35:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/62221)
5 years, 10 months ago (2015-02-25 22:42:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956813002/40001
5 years, 10 months ago (2015-02-25 23:01:44 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 00:08:24 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 00:09:10 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bb2b1f8842f408efdf295fb7202dbbaf447f943
Cr-Commit-Position: refs/heads/master@{#318152}

Powered by Google App Engine
This is Rietveld 408576698