Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 953143003: Remove unused transparency display item functions. (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
ajuma, chrishtr
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove unused transparency display item functions. Transparency display items have been replaced by the new compositing display items and are no longer needed. This patch also fixes an old fixme by removing FILTER_DISPLAY_ITEM_USES_FILTER_OPERATIONS. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190854

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M public/platform/WebDisplayItemList.h View 3 chunks +2 lines, -7 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
pdr.
5 years, 10 months ago (2015-02-25 04:36:44 UTC) #3
ajuma
lgtm https://codereview.chromium.org/953143003/diff/1/public/platform/WebDisplayItemList.h File public/platform/WebDisplayItemList.h (left): https://codereview.chromium.org/953143003/diff/1/public/platform/WebDisplayItemList.h#oldcode22 public/platform/WebDisplayItemList.h:22: #define FILTER_DISPLAY_ITEM_USES_FILTER_OPERATIONS 1 Thanks for cleaning this up!
5 years, 10 months ago (2015-02-25 14:11:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953143003/1
5 years, 10 months ago (2015-02-25 18:19:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:36:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190854

Powered by Google App Engine
This is Rietveld 408576698