Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: A few more TEs. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleBuilderCustom.cpp
diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp
index 4239ef7b8f88b797e81b034ee09258ff8fdff51b..6c13cd38786ebc98fc21fc4bdb7d27fc5713889f 100644
--- a/Source/core/css/resolver/StyleBuilderCustom.cpp
+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp
@@ -942,12 +942,13 @@ void StyleBuilderFunctions::applyValueCSSPropertyBaselineShift(StyleResolverStat
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
if (!primitiveValue->isValueID()) {
svgStyle.setBaselineShift(BS_LENGTH);
- svgStyle.setBaselineShiftValue(SVGLength::fromCSSPrimitiveValue(primitiveValue));
+ svgStyle.setBaselineShiftValue(StyleBuilderConverter::convertLength(state, primitiveValue));
return;
}
switch (primitiveValue->getValueID()) {
case CSSValueBaseline:
- svgStyle.setBaselineShift(BS_BASELINE);
+ svgStyle.setBaselineShift(BS_LENGTH);
+ svgStyle.setBaselineShiftValue(Length(Fixed));
return;
case CSSValueSub:
svgStyle.setBaselineShift(BS_SUB);

Powered by Google App Engine
This is Rietveld 408576698