Source/core/css/resolver/AnimatedStyleBuilder.cpp - Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/AnimatedStyleBuilder.cpp

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: A few more TEs. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/AnimatedStyleBuilder.cpp

diff --git a/Source/core/css/resolver/AnimatedStyleBuilder.cpp b/Source/core/css/resolver/AnimatedStyleBuilder.cpp

index a1d01855899a1c42651d2407d0e678d68fd4ef8d..2314e5ccd8fdd68ee648382cc957d522fa0b94c5 100644

--- a/Source/core/css/resolver/AnimatedStyleBuilder.cpp

+++ b/Source/core/css/resolver/AnimatedStyleBuilder.cpp

@@ -293,7 +293,8 @@ void AnimatedStyleBuilder::applyProperty(CSSPropertyID property, StyleResolverSt

setOnFillLayers<CSSPropertyBackgroundSize>(style->accessBackgroundLayers(), value, state);

return;

case CSSPropertyBaselineShift:

- style->setBaselineShiftValue(toAnimatableSVGLength(value)->toSVGLength());

+ style->accessSVGStyle().setBaselineShift(BS_LENGTH);

+ style->accessSVGStyle().setBaselineShiftValue(animatableValueToLength(value, state));

return;

case CSSPropertyBorderBottomColor:

style->setBorderBottomColor(toAnimatableColor(value)->color());