Source/core/layout/svg/SVGTextLayoutEngineBaseline.h - Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

Issue 956553004: Use Length for baselineShiftValue in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Drop SVGLengthContext changes for now. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/css/script-tests/scientific-numbers.js ('K') | « Source/core/layout/svg/SVGTextLayoutEngine.cpp ('k') | Source/core/layout/svg/SVGTextLayoutEngineBaseline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

diff --git a/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h b/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

index 6ce283171f3cd092ad251ed810e23551fd7b990b..8df8f7d707325e7c366903b6450a3a410f235ee2 100644

--- a/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

+++ b/Source/core/layout/svg/SVGTextLayoutEngineBaseline.h

@@ -27,7 +27,7 @@ namespace blink {

class Font;

class LayoutObject;

-class SVGElement;

+class LayoutStyle;

class SVGLayoutStyle;

class SVGTextMetrics;

@@ -37,7 +37,7 @@ class SVGTextLayoutEngineBaseline {

public:

SVGTextLayoutEngineBaseline(const Font&);

- float calculateBaselineShift(const SVGLayoutStyle&, SVGElement* lengthContext) const;

+ float calculateBaselineShift(const LayoutStyle&) const;

float calculateAlignmentBaselineShift(bool isVerticalText, const LayoutObject* textRenderer) const;

float calculateGlyphOrientationAngle(bool isVerticalText, const SVGLayoutStyle&, const UChar& character) const;

float calculateGlyphAdvanceAndOrientation(bool isVerticalText, const SVGTextMetrics&, float angle, float& xOrientationShift, float& yOrientationShift) const;