Rename DataReductionProxyUsageStats to DataReductionProxyBypassStats

Rename DataReductionProxyUsageStats to DataReductionProxyBypassStats

As the comment in data_reduction_proxy_usage_stats.h by bengr@,
rename DataReductionProxyUsageStats to DataReductionProxyBypassStats
and related class. Rename the files also.

BUG=462846
R=bengr@chromium.org

Committed: https://crrev.com/ee7aad6d7b4142405b0d3b7abf42754b81f5ef85
Cr-Commit-Position: refs/heads/master@{#323191}

[zhuoyu.qian, 2015-02-28 07:25:34]

Rename comments and variable and method names that refer to usage stats.
And rebase it.
Please have a look. Thank you.

[bengr, 2015-03-03 18:19:07]

On 2015/02/28 07:25:34, zhuoyu.qian wrote:
> Rename comments and variable and method names that refer to usage stats.
> And rebase it.
> Please have a look. Thank you.

How is this CL different from https://codereview.chromium.org/949533004/ ?

[zhuoyu.qian, 2015-03-04 01:11:54]

On 2015/03/03 18:19:07, bengr wrote:
> On 2015/02/28 07:25:34, zhuoyu.qian wrote:
> > Rename comments and variable and method names that refer to usage stats.
> > And rebase it.
> > Please have a look. Thank you.
> 
> How is this CL different from https://codereview.chromium.org/949533004/ ?

For this CL is rename DataReductionProxyUsageStats 
and the other is for  DataReductionProxyStatisticsPrefs
They are for different class in different files.
So there are two CL upload.
Please take a look for these two CL.
Thank you.

[bengr, 2015-03-16 23:42:50]

lgtm. Thanks for taking this on and sorry for the delay.

In the future, if you want to modify data reduction proxy code, please feel free
to contact me to discuss.

[zhuoyu.qian, 2015-03-17 01:57:30]

On 2015/03/16 23:42:50, bengr wrote:
> lgtm. Thanks for taking this on and sorry for the delay.
> 
> In the future, if you want to modify data reduction proxy code, please feel
free
> to contact me to discuss.

I've received your mail. For some reasons, I'm sorry I have to answer you here.
I think I can hold off on submit these two CLs until next week.
I will rebase them carefully, please take another look after I upload them.
Thank you for take care of these CLs.

[zhuoyu.qian, 2015-03-23 03:25:29]

Hi bengr,
I rebase this Cl, please take a look again.
and 
components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.*
need l-g-t-m.

[bengr, 2015-03-24 15:47:27]

Not lgtm

Please don't alter formatting that has nothing to do with the goal of this CL.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
(right):

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:147:
const TestCase test_cases[] = {{false, false, false},
Why did you change this? It has nothing to do with the renaming, and the style
is incorrect.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:233:
{true,
Same here. Please don't change the formatting.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:289:
const TestCase test_cases[] = {
And here.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:368:
const TestCase test_cases[] = {
And here. In this case the formatting is already a little busted, so you could
fix that up. Afaik, it should be like:

const TestCase test_cases[] = {
  { false, true, false, true, net::OK },
  ...
};

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:616:
GURL("http://foo.com"),
Again, please revert the formatting change.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:707:
"DataReductionProxy.BypassedBytes.ShortTriggeringRequest",
Here too.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:760:
"DataReductionProxy.BypassedBytes.MissingViaHeader4xx",
And here.

[zhuoyu.qian, 2015-03-28 03:06:58]

I revert the format not related rename.
PTAL.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
(right):

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:147:
const TestCase test_cases[] = {{false, false, false},
On 2015/03/24 15:47:27, bengr wrote:
> Why did you change this? It has nothing to do with the renaming, and the style
> is incorrect.

Done.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:233:
{true,
On 2015/03/24 15:47:27, bengr wrote:
> Same here. Please don't change the formatting.

Done.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:289:
const TestCase test_cases[] = {
On 2015/03/24 15:47:27, bengr wrote:
> And here.

Done.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:368:
const TestCase test_cases[] = {
On 2015/03/24 15:47:27, bengr wrote:
> And here. In this case the formatting is already a little busted, so you could
> fix that up. Afaik, it should be like:
> 
> const TestCase test_cases[] = {
>   { false, true, false, true, net::OK },
>   ...
> };

Done.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:616:
GURL("http://foo.com"),
On 2015/03/24 15:47:27, bengr wrote:
> Again, please revert the formatting change.

Done.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:707:
"DataReductionProxy.BypassedBytes.ShortTriggeringRequest",
On 2015/03/24 15:47:27, bengr wrote:
> Here too.

Done.

https://codereview.chromium.org/956223002/diff/40001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:760:
"DataReductionProxy.BypassedBytes.MissingViaHeader4xx",
On 2015/03/24 15:47:27, bengr wrote:
> And here.

Done.

[bengr, 2015-03-31 17:04:53]

You didn't revert all format changes, but I'm ok with the ones you left in,
except for the one I commented on.

https://codereview.chromium.org/956223002/diff/80001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
(right):

https://codereview.chromium.org/956223002/diff/80001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h:94:
NOT_BYPASSED = 0,       /* Not bypassed. */
Please revert this format change. Line comments should be two spaces from the
end of code. Maybe in another CL someone can change them to // comments.

[zhuoyu.qian, 2015-04-01 01:27:16]

Fix nits.

https://codereview.chromium.org/956223002/diff/80001/components/data_reductio...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h
(right):

https://codereview.chromium.org/956223002/diff/80001/components/data_reductio...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h:94:
NOT_BYPASSED = 0,       /* Not bypassed. */
On 2015/03/31 17:04:53, bengr wrote:
> Please revert this format change. Line comments should be two spaces from the
> end of code. Maybe in another CL someone can change them to // comments.

Done.

[bengr, 2015-04-01 04:59:38]

lgtm

[zhuoyu.qian, 2015-04-01 05:26:28]

The CQ bit was checked by zhuoyu.qian@samsung.com

[commit-bot: I haz the power, 2015-04-01 05:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/956223002/100001

[commit-bot: I haz the power, 2015-04-01 06:18:02]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-01 06:18:42]

Patchset 6 (id:??) landed as
https://crrev.com/ee7aad6d7b4142405b0d3b7abf42754b81f5ef85
Cr-Commit-Position: refs/heads/master@{#323191}