components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc - Issue 956223002: Rename DataReductionProxyUsageStats to DataReductionProxyBypassStats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

Issue 956223002: Rename DataReductionProxyUsageStats to DataReductionProxyBypassStats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/BUILD.gn ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

index 6abf87684904c3044d3c42e8b418fa6e025aa7b8..b39126311d2ce2db91f6ee8221dd97e5b214f298 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc

@@ -6,8 +6,8 @@

#include "base/strings/string_number_conversions.h"

#include "base/time/time.h"

+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h"

-#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"

@@ -113,7 +113,7 @@ bool DataReductionProxyBypassProtocol::MaybeBypassProxyAndPrepareToRetry(

// via header, so detect and report cases where the via header is missing.

const net::ProxyServer& second =

data_reduction_proxy_type_info.proxy_servers.second;

- DataReductionProxyUsageStats::DetectAndRecordMissingViaHeaderResponseCode(

+ DataReductionProxyBypassStats::DetectAndRecordMissingViaHeaderResponseCode(

second.is_valid() && !second.host_port_pair().IsEmpty(),

response_headers);

@@ -169,7 +169,7 @@ bool DataReductionProxyBypassProtocol::MaybeBypassProxyAndPrepareToRetry(

if (!config_->IsProxyBypassed(

request->context()->proxy_service()->proxy_retry_info(), proxy_server,

NULL)) {

- DataReductionProxyUsageStats::RecordDataReductionProxyBypassInfo(

+ DataReductionProxyBypassStats::RecordDataReductionProxyBypassInfo(

second.is_valid() && !second.host_port_pair().IsEmpty(),

data_reduction_proxy_info.bypass_all,

proxy_server,