Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 956143002: Revert of Use an image generator to back SkPictureShader tiles. (Closed)

Created:
5 years, 9 months ago by f(malita)
Modified:
5 years, 9 months ago
Reviewers:
hal.canary, mtklein, reed2, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use an image generator to back SkPictureShader tiles. (patchset #4 id:60001 of https://codereview.chromium.org/866773002/) Reason for revert: TSAN troubles. Original issue's description: > Use an image generator to back SkPictureShader tiles. > > To avoid lifetime issues for tiles backed by discardable memory, use an > image generator to re-generate them on the fly. > > With this CL, we are now caching bitmap shaders wrapping discardable > pixel ref bitmaps backed by picture image generators. > > (the CL also includes some minor/unrelated SkPictureShader cleanup) > > BUG=skia:3220 > R=reed@google.com,halcanary@google.com > > Committed: https://skia.googlesource.com/skia/+/4739955e98ba86900a5bbac0e3661601427a54d4 TBR=reed@google.com,halcanary@google.com,mtklein@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3220 Committed: https://skia.googlesource.com/skia/+/f47e70712b964b5360a3fec9e5e84bb594fc1f02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -57 lines) Patch
M src/core/SkPictureShader.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkPictureShader.cpp View 6 chunks +33 lines, -54 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
f(malita)
Created Revert of Use an image generator to back SkPictureShader tiles.
5 years, 9 months ago (2015-02-26 01:45:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/956143002/1
5 years, 9 months ago (2015-02-26 01:46:59 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 01:47:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f47e70712b964b5360a3fec9e5e84bb594fc1f02

Powered by Google App Engine
This is Rietveld 408576698