Subzero: Change the name llvm2ice to the more appropriate pnacl-sz.

Subzero: Change the name llvm2ice to the more appropriate pnacl-sz.

Most of this is a mechanical change of 'llvm2ice' to 'pnacl-sz'.  This is a convenient naming choice because both strings are the same length which minimizes the need for line length reformatting.

Python variables needed to use pnacl_sz instead, and sometimes pnacl_sz_ .

The IceConverter still uses LLVM2Ice naming, which is actually appropriate there since it actually converts LLVM IR into ICE.

I will rename tests_lit/llvm2ice_tests/ in a separate CL, otherwise this CL will look misleadingly massive and no one will review it.

BUG= none
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fa0cfa5b234030541ec43bca17757840a79cbff4

[Jim Stichnoth, 2015-02-26 00:04:34]

stichnot@chromium.org changed reviewers:
+ dschuff@chromium.org, jfb@chromium.org, jvoung@chromium.org,
kschimpf@google.com, mtrofin@chromium.org

[Karl, 2015-02-26 17:03:34]

LGTM after nits.

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone#newc...
Makefile.standalone:130: main.cpp \
Should the tab be removed here?

https://codereview.chromium.org/956123002/diff/60001/README.rst
File README.rst (right):

https://codereview.chromium.org/956123002/diff/60001/README.rst#newcode48
README.rst:48: ../pnacl-sz ./path/to/<file>.pexe
Doesn't this require -build-on-read?

[Jim Stichnoth, 2015-02-26 17:11:33]

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone#newc...
Makefile.standalone:130: main.cpp \
On 2015/02/26 17:03:34, Karl wrote:
> Should the tab be removed here?

Tabs are required in makefiles.  The other files also have tabs, but they're
just not highlighted in this view.

https://codereview.chromium.org/956123002/diff/60001/README.rst
File README.rst (right):

https://codereview.chromium.org/956123002/diff/60001/README.rst#newcode48
README.rst:48: ../pnacl-sz ./path/to/<file>.pexe
On 2015/02/26 17:03:34, Karl wrote:
> Doesn't this require -build-on-read?

No, thanks to a magical moment:

https://codereview.chromium.org/732583002/ - Auto-set -build-on-read=0 for .ll
input files

build-on-read defaults to 1, and is forced to 0 if the input filename ends with
.ll .

[Jim Stichnoth, 2015-02-26 17:13:44]

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone#newc...
Makefile.standalone:130: main.cpp \
On 2015/02/26 17:11:33, stichnot wrote:
> On 2015/02/26 17:03:34, Karl wrote:
> > Should the tab be removed here?
> 
> Tabs are required in makefiles.  The other files also have tabs, but they're
> just not highlighted in this view.

Sorry, to clarify, I mean the other .cpp files in the list above main.cpp.  (not
the actual contents of non-makefiles)

[Karl, 2015-02-26 17:18:28]

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone#newc...
Makefile.standalone:130: main.cpp \
On 2015/02/26 17:13:43, stichnot wrote:
> On 2015/02/26 17:11:33, stichnot wrote:
> > On 2015/02/26 17:03:34, Karl wrote:
> > > Should the tab be removed here?
> > 
> > Tabs are required in makefiles.  The other files also have tabs, but they're
> > just not highlighted in this view.
> 
> Sorry, to clarify, I mean the other .cpp files in the list above main.cpp. 
(not
> the actual contents of non-makefiles)

Not for line 130! Like the previous 22 lines that doesn't have one.

[Karl, 2015-02-26 17:22:01]

LGTM. Otherwise

[Derek Schuff, 2015-02-26 17:29:10]

On 2015/02/26 17:22:01, Karl wrote:
> LGTM. Otherwise
maybe you should call it pnacl_subz instead

༼ ͒ ͓ ͒༽

[Jim Stichnoth, 2015-02-26 17:31:15]

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/956123002/diff/60001/Makefile.standalone#newc...
Makefile.standalone:130: main.cpp \
On 2015/02/26 17:18:28, Karl wrote:
> On 2015/02/26 17:13:43, stichnot wrote:
> > On 2015/02/26 17:11:33, stichnot wrote:
> > > On 2015/02/26 17:03:34, Karl wrote:
> > > > Should the tab be removed here?
> > > 
> > > Tabs are required in makefiles.  The other files also have tabs, but
they're
> > > just not highlighted in this view.
> > 
> > Sorry, to clarify, I mean the other .cpp files in the list above main.cpp. 
> (not
> > the actual contents of non-makefiles)
> 
> Not for line 130! Like the previous 22 lines that doesn't have one.

Please check your local copy of Makefile.standalone, you will find that lines
108-131 all start with a tab character.  Rietveld only highlights tab characters
in lines that were changed.

I looked at the rules again, and it seems that a tab character is only required
for commands, so assignment lines like this could get away with spaces only. 
That's probably a good idea (with 2-space indentation), but for a separate CL. 
(Maybe the same CL that fixes our python scripts to use 2-space indents...)

[Jim Stichnoth, 2015-02-26 17:42:41]

Committed patchset #4 (id:60001) manually as
fa0cfa5b234030541ec43bca17757840a79cbff4 (presubmit successful).