Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: Makefile.standalone

Issue 956123002: Subzero: Change the name llvm2ice to the more appropriate pnacl-sz. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Make comment correct Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gitignore ('k') | README.rst » ('j') | README.rst » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile.standalone
diff --git a/Makefile.standalone b/Makefile.standalone
index 5f652bdc9a2c53547b95efe6528dc43a22e960eb..afaec7e4f03c3bedb46c804bbf83cf92acb84e3e 100644
--- a/Makefile.standalone
+++ b/Makefile.standalone
@@ -127,7 +127,7 @@ SRCS = \
IceTimerTree.cpp \
IceTranslator.cpp \
IceTypes.cpp \
- llvm2ice.cpp \
+ main.cpp \
Karl 2015/02/26 17:03:34 Should the tab be removed here?
Jim Stichnoth 2015/02/26 17:11:33 Tabs are required in makefiles. The other files a
Jim Stichnoth 2015/02/26 17:13:43 Sorry, to clarify, I mean the other .cpp files in
Karl 2015/02/26 17:18:28 Not for line 130! Like the previous 22 lines that
Jim Stichnoth 2015/02/26 17:31:15 Please check your local copy of Makefile.standalon
PNaClTranslator.cpp
ifndef MINIMAL
@@ -143,23 +143,23 @@ UNITTEST_SRCS = \
IceParseInstsTest.cpp
UNITTEST_OBJS = $(patsubst %.cpp, $(OBJDIR)/unittest/%.o, $(UNITTEST_SRCS))
-UNITTEST_LIB_OBJS = $(filter-out $(OBJDIR)/llvm2ice.o,$(OBJS))
+UNITTEST_LIB_OBJS = $(filter-out $(OBJDIR)/main.o,$(OBJS))
# Keep all the first target so it's the default.
-all: $(OBJDIR)/llvm2ice make_symlink runtime
+all: $(OBJDIR)/pnacl-sz make_symlink runtime
# Creates symbolic link so that testing is easier. Also runs
-# llvm2ice to verify that the defines flags have valid values,
+# pnacl-sz to verify that the defines flags have valid values,
# as well as describe the corresponding build attributes.
-make_symlink: $(OBJDIR)/llvm2ice
- rm -rf llvm2ice
- ln -s $(OBJDIR)/llvm2ice
+make_symlink: $(OBJDIR)/pnacl-sz
+ rm -rf pnacl-sz
+ ln -s $(OBJDIR)/pnacl-sz
@echo "Build Attributes:"
- @$(OBJDIR)/llvm2ice --build-atts
+ @$(OBJDIR)/pnacl-sz --build-atts
.PHONY: all make_symlink runtime bloat
-$(OBJDIR)/llvm2ice: $(OBJS)
+$(OBJDIR)/pnacl-sz: $(OBJS)
$(CXX) $(LDFLAGS) -o $@ $^ $(LLVM_LDFLAGS) \
-Wl,-rpath=$(abspath $(LIBCXX_INSTALL_PATH)/lib)
@@ -202,7 +202,7 @@ runtime.is.built: $(RT_SRC)
@echo ================ Building Subzero runtime ================
./pydir/build-runtime.py -v
-check-lit: $(OBJDIR)/llvm2ice make_symlink
+check-lit: $(OBJDIR)/pnacl-sz make_symlink
LLVM_BIN_PATH=$(LLVM_BIN_PATH) \
BINUTILS_BIN_PATH=$(BINUTILS_BIN_PATH) \
$(LLVM_SRC_PATH)/utils/lit/lit.py -sv tests_lit
@@ -232,12 +232,12 @@ format-diff:
-p1 -style=LLVM -i
bloat: make_symlink
- nm -C -S -l llvm2ice | \
- bloat/bloat.py --nm-output=/dev/stdin syms > build/llvm2ice.bloat.json
- @echo See Subzero size breakdown in bloat/llvm2ice.bloat.html
+ nm -C -S -l pnacl-sz | \
+ bloat/bloat.py --nm-output=/dev/stdin syms > build/pnacl-sz.bloat.json
+ @echo See Subzero size breakdown in bloat/pnacl-sz.bloat.html
clean:
- rm -rf llvm2ice *.o $(OBJDIR) build/llvm2ice.bloat.json
+ rm -rf pnacl-sz *.o $(OBJDIR) build/pnacl-sz.bloat.json
clean-all: clean
rm -rf build/
« no previous file with comments | « .gitignore ('k') | README.rst » ('j') | README.rst » ('J')

Powered by Google App Engine
This is Rietveld 408576698