Handle KeyboardInterrupt consistently in python scripts

Handle KeyboardInterrupt consistently in python scripts

Handle KeyboardInterrupt gracefully rather the printing a
backtrace. Most users of these tools don't expect a
backtrace when then hit Ctrl-C.

Also, fix a few other inconsistencies found in the python
startup code of these different scripts:
- always call main function 'main' (rather than 'Main')
- always return 0 from main function
- if main takes args never include argv[0]

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294250

[Sam Clegg, 2015-02-26 00:46:56]

sbc@chromium.org changed reviewers:
+ maruel@chromium.org

[Sam Clegg, 2015-02-26 00:51:36]

I considered also having main always take args=None and never passing
sys.argv[1], but this change was getting a little big.

[M-A Ruel, 2015-02-26 00:57:40]

Only change is could you print to sys.stderr instead?

https://codereview.chromium.org/955993006/diff/60001/git_number.py
File git_number.py (right):

https://codereview.chromium.org/955993006/diff/60001/git_number.py#newcode278
git_number.py:278: except KeyboardInterrupt:
It's already handled there, worth removing

https://codereview.chromium.org/955993006/diff/60001/git_upstream_diff.py
File git_upstream_diff.py (right):

https://codereview.chromium.org/955993006/diff/60001/git_upstream_diff.py#new...
git_upstream_diff.py:41: subprocess2.check_call(cmd)
return subprocess2.check_call(cmd)

[Sam Clegg, 2015-02-26 17:29:21]

Done.

https://codereview.chromium.org/955993006/diff/60001/git_number.py
File git_number.py (right):

https://codereview.chromium.org/955993006/diff/60001/git_number.py#newcode278
git_number.py:278: except KeyboardInterrupt:
On 2015/02/26 00:57:39, M-A Ruel wrote:
> It's already handled there, worth removing

Done.

https://codereview.chromium.org/955993006/diff/60001/git_upstream_diff.py
File git_upstream_diff.py (right):

https://codereview.chromium.org/955993006/diff/60001/git_upstream_diff.py#new...
git_upstream_diff.py:41: subprocess2.check_call(cmd)
On 2015/02/26 00:57:39, M-A Ruel wrote:
> return subprocess2.check_call(cmd)

Done.

[M-A Ruel, 2015-02-26 17:49:22]

lgtm, thanks!

[Sam Clegg, 2015-02-26 18:24:23]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2015-02-26 18:24:24]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/955993006/#ps100001
(title: "tweek test expectations")

[commit-bot: I haz the power, 2015-02-26 18:25:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/955993006/100001

[commit-bot: I haz the power, 2015-02-26 18:28:45]

Committed patchset #6 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294250

[yosin_UTC9, 2015-02-28 13:11:55]

yosin@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2015-02-28 13:11:56]

https://codereview.chromium.org/955993006/diff/100001/clang_format.py
File clang_format.py (right):

https://codereview.chromium.org/955993006/diff/100001/clang_format.py#newcode70
clang_format.py:70: sys.exit(main(sys.argv[1]))
Q: Is using |argv[1]| rather than |argv[1:]| intentional?
I got error following error with Python 2.7.6:

Traceback (most recent call last):
  File "d:\w\depot_tools\\clang_format.py", line 70, in <module>
    sys.exit(main(sys.argv[1]))
  File "d:\w\depot_tools\\clang_format.py", line 65, in main
    return subprocess.call([tool] + args)
TypeError: can only concatenate list (not "str") to list

[Sam Clegg, 2015-02-28 15:33:12]

On 2015/02/28 13:11:56, Yosi_UTC9 wrote:
> https://codereview.chromium.org/955993006/diff/100001/clang_format.py
> File clang_format.py (right):
> 
>
https://codereview.chromium.org/955993006/diff/100001/clang_format.py#newcode70
> clang_format.py:70: sys.exit(main(sys.argv[1]))
> Q: Is using |argv[1]| rather than |argv[1:]| intentional?
> I got error following error with Python 2.7.6:
> 
> Traceback (most recent call last):
>   File "d:\w\depot_tools\\clang_format.py", line 70, in <module>
>     sys.exit(main(sys.argv[1]))
>   File "d:\w\depot_tools\\clang_format.py", line 65, in main
>     return subprocess.call([tool] + args)
> TypeError: can only concatenate list (not "str") to list

Sorry, no.  My bad.  Will fix when I get to my machine (please fix with TBR or
revert in the mean time if you like)

[tfarina, 2015-02-28 18:59:27]

https://codereview.chromium.org/955993006/diff/100001/clang_format.py
File clang_format.py (right):

https://codereview.chromium.org/955993006/diff/100001/clang_format.py#newcode65
clang_format.py:65: return subprocess.call([tool] + args)
Looks like this broke my setup!

Traceback (most recent call last):
  File "/home/tfarina/depot_tools/clang_format.py", line 70, in <module>
    sys.exit(main(sys.argv[1]))
  File "/home/tfarina/depot_tools/clang_format.py", line 65, in main
    return subprocess.call([tool] + args)
TypeError: can only concatenate list (not "str") to list
No output from clang-format (crashed?).
Please report to bugs.llvm.org.

Which version of Python supports that?

[tfarina, 2015-02-28 19:07:06]

I have a fix for that -> https://codereview.chromium.org/972453002