Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 972453002: Fix the argument passed to main() in clang_format.py (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
M-A Ruel, Sam Clegg
CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, yosin_UTC9
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Fix the argument passed to main() in clang_format.py Passing arg[1] rather than argv[1:] is causing the following with Python 2.7.3. Traceback (most recent call last): File "/home/tfarina/depot_tools/clang_format.py", line 70, in <module> sys.exit(main(sys.argv[1])) File "/home/tfarina/depot_tools/clang_format.py", line 65, in main return subprocess.call([tool] + args) TypeError: can only concatenate list (not "str") to list No output from clang-format (crashed?). Please report to bugs.llvm.org. This started to happening after http://src.chromium.org/viewvc/chrome?view=rev&revision=294250 BUG=None TEST=try to format a c++ file using clang-format TBR=sbc@chromium.org,maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M clang_format.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tfarina
TBRing...
5 years, 9 months ago (2015-02-28 19:07:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972453002/1
5 years, 9 months ago (2015-02-28 19:08:24 UTC) #3
commit-bot: I haz the power
Presubmit check for 972453002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-02-28 19:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/972453002/1
5 years, 9 months ago (2015-02-28 19:17:26 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 19:20:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294267

Powered by Google App Engine
This is Rietveld 408576698