Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 955973003: Remove effectful assertion (Closed)

Created:
5 years, 10 months ago by rossberg
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove effectful assertion R=mstarzinger@chromium.org BUG=461520 LOG=N Committed: https://crrev.com/68c8073a514b88f9dac4e8e594be62db59a33b3c Cr-Commit-Position: refs/heads/master@{#26857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M src/runtime/runtime-scopes.cc View 1 chunk +0 lines, -7 lines 0 comments Download
A test/mjsunit/harmony/regress/regress-crbug-461520.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 10 months ago (2015-02-25 15:05:45 UTC) #1
Michael Starzinger
LGTM.
5 years, 10 months ago (2015-02-25 15:07:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955973003/1
5 years, 10 months ago (2015-02-25 15:12:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 15:34:12 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:34:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/68c8073a514b88f9dac4e8e594be62db59a33b3c
Cr-Commit-Position: refs/heads/master@{#26857}

Powered by Google App Engine
This is Rietveld 408576698