src/runtime/runtime-scopes.cc - Issue 955973003: Remove effectful assertion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-scopes.cc

Issue 955973003: Remove effectful assertion (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-scopes.cc

diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc

index 201bf9d4c683030fcdcc3a15d94a7b51b02869ca..7bba26314b2ee276db27d038a64a18575bf01ecc 100644

--- a/src/runtime/runtime-scopes.cc

+++ b/src/runtime/runtime-scopes.cc

@@ -933,13 +933,6 @@ static ObjectPair LoadLookupSlotHelper(Arguments args, Isolate* isolate,

// property from it.

if (!holder.is_null()) {

Handle<JSReceiver> object = Handle<JSReceiver>::cast(holder);

-#ifdef DEBUG

- if (!object->IsJSProxy()) {

- Maybe<bool> maybe = JSReceiver::HasProperty(object, name);

- DCHECK(maybe.has_value);

- DCHECK(maybe.value);

- }

-#endif

// GetProperty below can cause GC.

Handle<Object> receiver_handle(

object->IsGlobalObject()

« no previous file with comments | « no previous file | test/mjsunit/harmony/regress/regress-crbug-461520.js » ('j') | no next file with comments »