Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 955873002: Delete some dead code. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete some dead code. And reduce my TODO count in the process. Committed: https://crrev.com/d6b95a86b557e8eb1b06cb1891682cd3d3448fc3 Cr-Commit-Position: refs/heads/master@{#317983}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 10 months ago (2015-02-25 02:33:24 UTC) #2
aurimas (slooooooooow)
lgtm https://codereview.chromium.org/955873002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (left): https://codereview.chromium.org/955873002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#oldcode861 chrome/android/java/strings/android_chrome_strings.grd:861: <!-- TODO(newt): remove duplicated strings once crbug.com/176069 is ...
5 years, 10 months ago (2015-02-25 02:49:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955873002/1
5 years, 10 months ago (2015-02-25 03:01:39 UTC) #5
newt (away)
On 2015/02/25 02:49:45, aurimas wrote: > lgtm > > https://codereview.chromium.org/955873002/diff/1/chrome/android/java/strings/android_chrome_strings.grd > File chrome/android/java/strings/android_chrome_strings.grd (left): > ...
5 years, 10 months ago (2015-02-25 03:02:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 05:04:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 05:05:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6b95a86b557e8eb1b06cb1891682cd3d3448fc3
Cr-Commit-Position: refs/heads/master@{#317983}

Powered by Google App Engine
This is Rietveld 408576698