chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java - Issue 955873002: Delete some dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java

Issue 955873002: Delete some dead code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java

index d3a33e6bda8ab3a391d142ccb6e84d2a2dd0df45..7802fe471d7dd1a591b3f9ed94c2d7fad7c3cb2f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java

@@ -6,7 +6,6 @@ package org.chromium.chrome.browser;

import org.chromium.base.CalledByNative;

import org.chromium.chrome.browser.profiles.Profile;

-import org.chromium.ui.WindowOpenDisposition;

import java.util.ArrayList;

import java.util.List;

@@ -95,18 +94,6 @@ public class RecentlyClosedBridge {

return received ? tabs : null;

}

- // TODO(newt): delete this once all callers are using the new method below.

- /**

- * Opens a recently closed tab in the current tab.

- *

- * @param tab The current Tab.

- * @param recentTab The RecentlyClosedTab to open.

- * @return Whether the tab was successfully opened.

- */

- public boolean openRecentlyClosedTab(Tab tab, RecentlyClosedTab recentTab) {

- return openRecentlyClosedTab(tab, recentTab, WindowOpenDisposition.CURRENT_TAB);

- }

/**

* Opens a recently closed tab in the current tab or a new tab. If opened in the current tab,

* the current tab's entire history is replaced.