Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 955703002: Add ExitFunnel instrumentation to browser rendezvous path. (Closed)

Created:
5 years, 10 months ago by Sigurður Ásgeirsson
Modified:
5 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ExitFunnel instrumentation to browser rendezvous path. BUG=412384 Committed: https://crrev.com/615f8232af4ae7be355c2951b93a39d0d06d1cc8 Cr-Commit-Position: refs/heads/master@{#317850}

Patch Set 1 #

Patch Set 2 : Add Windows-only compilation guard. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Sigurður Ásgeirsson
Hey guys, PTAL. I suspect this is affecting ~3% of users/day or so. Siggi
5 years, 10 months ago (2015-02-24 16:00:26 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-24 16:06:37 UTC) #3
erikwright (departed)
lgtm
5 years, 10 months ago (2015-02-24 16:07:35 UTC) #4
sky
LGTM
5 years, 10 months ago (2015-02-24 17:11:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955703002/20001
5 years, 10 months ago (2015-02-24 18:20:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 19:19:18 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 19:19:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/615f8232af4ae7be355c2951b93a39d0d06d1cc8
Cr-Commit-Position: refs/heads/master@{#317850}

Powered by Google App Engine
This is Rietveld 408576698