Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 955703002: Add ExitFunnel instrumentation to browser rendezvous path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add Windows-only compilation guard. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index cfd3b103a6e5876a138b6d11edaa2cd61589bbd5..3af4c611d1d4f5ae87ea353d7983a8d746302712 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -176,6 +176,7 @@
#include "chrome/installer/util/helper.h"
#include "chrome/installer/util/install_util.h"
#include "chrome/installer/util/shell_util.h"
+#include "components/browser_watcher/exit_funnel_win.h"
#include "net/base/net_util.h"
#include "ui/base/l10n/l10n_util_win.h"
#include "ui/gfx/win/dpi.h"
@@ -465,8 +466,15 @@ bool ProcessSingletonNotificationCallback(
const base::CommandLine& command_line,
const base::FilePath& current_directory) {
// Drop the request if the browser process is already in shutdown path.
- if (!g_browser_process || g_browser_process->IsShuttingDown())
+ if (!g_browser_process || g_browser_process->IsShuttingDown()) {
+#if defined(OS_WIN)
+ browser_watcher::ExitFunnel::RecordSingleEvent(
+ chrome::kBrowserExitCodesRegistryPath,
+ L"ProcessSingletonIsShuttingDown");
+#endif
+
return false;
+ }
if (command_line.HasSwitch(switches::kOriginalProcessStartTime)) {
std::string start_time_string =
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698