Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 955483002: Update the script that downloads the dart sdk so we can roll it. (Closed)

Created:
5 years, 10 months ago by Elliot Glaysher
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update the script that downloads the dart sdk so we can roll it. Then roll the SDK. This will let us pick up the changes to dartanalyzer so we can run it as a build step. BUG=459376 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d21890ec71f93a9f8a68f38467304aacad4a634c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M tools/dart/update.py View 2 chunks +35 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Elliot Glaysher
5 years, 10 months ago (2015-02-23 22:00:13 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-23 22:05:07 UTC) #3
Elliot Glaysher
Committed patchset #1 (id:1) manually as d21890ec71f93a9f8a68f38467304aacad4a634c (presubmit successful).
5 years, 10 months ago (2015-02-23 22:17:18 UTC) #4
azani
On 2015/02/23 22:17:18, Elliot Glaysher wrote: > Committed patchset #1 (id:1) manually as > d21890ec71f93a9f8a68f38467304aacad4a634c ...
5 years, 10 months ago (2015-02-26 00:17:11 UTC) #5
Elliot Glaysher
5 years, 9 months ago (2015-02-26 18:41:10 UTC) #6
Message was sent while issue was closed.
On 2015/02/26 00:17:11, azani wrote:
> On 2015/02/23 22:17:18, Elliot Glaysher wrote:
> > Committed patchset #1 (id:1) manually as
> > d21890ec71f93a9f8a68f38467304aacad4a634c (presubmit successful).
> 
> It looks like gclient sync doesn't behave well if dart-sdk/ does not already
> exist. I can't confirm that it is related to this patch, but this looks like
the
> most likely culprit.

Did you roll past https://codereview.chromium.org/943843003/ ? We were seeing
something like that on only one of the trybots, but not the main waterfall.

Powered by Google App Engine
This is Rietveld 408576698