Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: tools/dart/update.py

Issue 955483002: Update the script that downloads the dart sdk so we can roll it. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dart/update.py
diff --git a/tools/dart/update.py b/tools/dart/update.py
index 59da8ca0d67d3ff0e6a2e844ed2178024d06e740..3bc9a63759b32dd1132177a4bdc8181912af4854 100755
--- a/tools/dart/update.py
+++ b/tools/dart/update.py
@@ -3,24 +3,29 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-"""Pulls down the current dart sdk to third_party/dart-sdk/."""
+"""Pulls down the current dart sdk to third_party/dart-sdk/.
+
+You can manually force this to run again by removing
+third_party/dart-sdk/STAMP_FILE, which contains the URL of the SDK that
+was downloaded. Rolling works by updating LINUX_64_SDK to a new URL.
+"""
import os
+import shutil
import subprocess
import sys
+# How to roll the dart sdk: Just change this url! We write this to the stamp
+# file after we download, and then check the stamp file for differences.
+LINUX_64_SDK = ('http://gsdview.appspot.com/dart-archive/channels/dev/' +
+ 'raw/43903/sdk/dartsdk-linux-x64-release.zip')
+
# Path constants. (All of these should be absolute paths.)
THIS_DIR = os.path.abspath(os.path.dirname(__file__))
CHROMIUM_DIR = os.path.abspath(os.path.join(THIS_DIR, '..', '..'))
DART_SDK_DIR = os.path.join(CHROMIUM_DIR, 'third_party', 'dart-sdk')
-
-# TODO(erg): We might want 32 bit linux too? I don't know of anyone who still
-# uses that though. It looks like clang isn't built 32 bit.
-
-LINUX_64_SDK = ('http://gsdview.appspot.com/dart-archive/channels/dev/' +
- 'raw/43808/sdk/dartsdk-linux-x64-release.zip')
-
OUTPUT_FILE = os.path.join(DART_SDK_DIR, 'dartsdk-linux-x64-release.zip')
+STAMP_FILE = os.path.join(DART_SDK_DIR, 'STAMP_FILE')
def RunCommand(command, fail_hard=True):
"""Run command and return success (True) or failure; or if fail_hard is
@@ -35,21 +40,35 @@ def RunCommand(command, fail_hard=True):
return False
def main():
- # For version one, we don't actually redownload if the sdk is already
- # present. This will be replaced with download_from_google_storage once
- # it supports tarballs.
- #
- # You can explicitly redownload this by blowing away your
- # third_party/dart-sdk/ directory.
- if not os.path.exists(OUTPUT_FILE):
+ # Only get the SDK if we don't have a stamp for or have an out of date stamp
+ # file.
+ get_sdk = False
+ if not os.path.exists(STAMP_FILE):
+ get_sdk = True
+ else:
+ # Get the contents of the stamp file.
+ with open(STAMP_FILE, "r") as stamp_file:
+ stamp_url = stamp_file.read().replace('\n', '')
+ if stamp_url != LINUX_64_SDK:
+ get_sdk = True
+
+ if get_sdk:
+ # Completely remove all traces of the previous SDK.
+ shutil.rmtree(DART_SDK_DIR)
+ os.mkdir(DART_SDK_DIR)
+
wget_command = ['wget', '-N', '-c', LINUX_64_SDK, '-P', DART_SDK_DIR]
if not RunCommand(wget_command, fail_hard=False):
print "Failed to get dart sdk from server."
return
- unzip_command = ['unzip', '-q', OUTPUT_FILE, '-d', DART_SDK_DIR]
+ unzip_command = ['unzip', '-o', '-q', OUTPUT_FILE, '-d', DART_SDK_DIR]
if not RunCommand(unzip_command, fail_hard=False):
print "Failed to unzip the dart sdk."
+ # Write our stamp file so we don't redownload the sdk.
+ with open(STAMP_FILE, "w") as stamp_file:
+ stamp_file.write(LINUX_64_SDK)
+
if __name__ == '__main__':
sys.exit(main())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698