Issue 955443003: [VS Addin] Fix error handling on webserver startup error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 955443003: [VS Addin] Fix error handling on webserver startup error (Closed)

Created:
5 years, 10 months ago by Sam Clegg

Modified:
5 years, 10 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

[VS Addin] Fix error handling on webserver startup error We were previously clearing the output page after the error message was printed meaning that the error was not showing up in Visual Studio. This error occurs if python.exe is not found in PATH. TEST=local testing R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1580

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/WebServer.cs	View		2 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sam Clegg

5 years, 10 months ago (2015-02-24 00:26:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 1580 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages