Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: Source/core/html/track/TextTrackCueList.h

Issue 955443002: Replace open-coded binary search in TextTrackCueList::add with upper_bound (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Re-add add() in updateCueIndex. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCueList.h
diff --git a/Source/core/html/track/TextTrackCueList.h b/Source/core/html/track/TextTrackCueList.h
index 3bdeea814894a0f8026983d3f0c9b6c38e5d0eec..0f11f2b60c2de7ec35dd749a0dda0211619a59a4 100644
--- a/Source/core/html/track/TextTrackCueList.h
+++ b/Source/core/html/track/TextTrackCueList.h
@@ -53,13 +53,13 @@ public:
bool add(PassRefPtrWillBeRawPtr<TextTrackCue>);
bool remove(TextTrackCue*);
- bool updateCueIndex(TextTrackCue*);
+ void updateCueIndex(TextTrackCue*);
DECLARE_TRACE();
private:
TextTrackCueList();
- bool add(PassRefPtrWillBeRawPtr<TextTrackCue>, size_t, size_t);
+ size_t findInsertionIndex(const TextTrackCue*) const;
void clear();
void invalidateCueIndexes(size_t);
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698