Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: Source/core/html/track/TextTrackCueList.h

Issue 955443002: Replace open-coded binary search in TextTrackCueList::add with upper_bound (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Re-add add() in updateCueIndex. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 unsigned long length() const; 46 unsigned long length() const;
47 unsigned long getCueIndex(TextTrackCue*) const; 47 unsigned long getCueIndex(TextTrackCue*) const;
48 48
49 TextTrackCue* item(unsigned index) const; 49 TextTrackCue* item(unsigned index) const;
50 TextTrackCue* getCueById(const AtomicString&) const; 50 TextTrackCue* getCueById(const AtomicString&) const;
51 TextTrackCueList* activeCues(); 51 TextTrackCueList* activeCues();
52 52
53 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>); 53 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>);
54 bool remove(TextTrackCue*); 54 bool remove(TextTrackCue*);
55 55
56 bool updateCueIndex(TextTrackCue*); 56 void updateCueIndex(TextTrackCue*);
57 57
58 DECLARE_TRACE(); 58 DECLARE_TRACE();
59 59
60 private: 60 private:
61 TextTrackCueList(); 61 TextTrackCueList();
62 bool add(PassRefPtrWillBeRawPtr<TextTrackCue>, size_t, size_t); 62 size_t findInsertionIndex(const TextTrackCue*) const;
63 void clear(); 63 void clear();
64 void invalidateCueIndexes(size_t); 64 void invalidateCueIndexes(size_t);
65 65
66 WillBeHeapVector<RefPtrWillBeMember<TextTrackCue>> m_list; 66 WillBeHeapVector<RefPtrWillBeMember<TextTrackCue>> m_list;
67 RefPtrWillBeMember<TextTrackCueList> m_activeCues; 67 RefPtrWillBeMember<TextTrackCueList> m_activeCues;
68 }; 68 };
69 69
70 } // namespace blink 70 } // namespace blink
71 71
72 #endif // TextTrackCueList_h 72 #endif // TextTrackCueList_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/track/TextTrackCueList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698