Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/public/browser/content_browser_client.cc

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/geolocation/geolocation_permission_context.cc ('K') | « content/public/browser/content_browser_client.h ('k') | content/shell/browser/layout_test/layout_test_content_browser_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/content_browser_client.cc
diff --git a/content/public/browser/content_browser_client.cc b/content/public/browser/content_browser_client.cc
index 67d2df7c1bf839247279e9a134aa3e7a52900f22..96c076a602de161ea5e0fb2a3a789d3ab8d9e315 100644
--- a/content/public/browser/content_browser_client.cc
+++ b/content/public/browser/content_browser_client.cc
@@ -230,8 +230,8 @@ void ContentBrowserClient::RequestPermission(
int bridge_id,
const GURL& requesting_frame,
bool user_gesture,
- const base::Callback<void(bool)>& result_callback) {
- result_callback.Run(true);
+ const base::Callback<void(PermissionStatus)>& callback) {
+ callback.Run(PERMISSION_STATUS_DENIED);
}
PermissionStatus ContentBrowserClient::GetPermissionStatus(
« chrome/browser/geolocation/geolocation_permission_context.cc ('K') | « content/public/browser/content_browser_client.h ('k') | content/shell/browser/layout_test/layout_test_content_browser_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698