chrome/browser/geolocation/geolocation_permission_context.cc - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context.cc

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_queue_controller_unittest.cc ('k') | chrome/browser/geolocation/geolocation_permission_context_extensions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context.cc b/chrome/browser/geolocation/geolocation_permission_context.cc

index a183871da7fbe65a1e31966f1111826818804084..d535e8ff83fa9e2a804d27c41887f36b1a950ca3 100644

--- a/chrome/browser/geolocation/geolocation_permission_context.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context.cc

@@ -36,12 +36,10 @@ void GeolocationPermissionContext::RequestPermission(

web_contents, id, id.bridge_id(), requesting_frame_origin, user_gesture,

callback, &permission_set, &new_permission)) {

if (permission_set) {

- NotifyPermissionSet(id,

- requesting_frame_origin,

- web_contents->GetLastCommittedURL().GetOrigin(),

- callback,

- true,

- new_permission);

+ NotifyPermissionSet(

+ id, requesting_frame_origin,

+ web_contents->GetLastCommittedURL().GetOrigin(), callback, true,

+ new_permission ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK);

Michael van Ouwerkerk 2015/02/26 15:09:49 nit: the call to NotifyPermissionSet would be a bi

mlamouri (slow - plz ping) 2015/02/26 21:19:38 Done.

}

return;

}