ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

chrome/browser/geolocation/geolocation_permission_context.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include "base/bind.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/content_settings/core/common/permission_request_id.h"
@@ skipping 18 matching lines @@
     bool user_gesture,
     const BrowserPermissionCallback& callback) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   bool permission_set;
   bool new_permission;
   if (extensions_context_.RequestPermission(
       web_contents, id, id.bridge_id(), requesting_frame_origin, user_gesture,
       callback, &permission_set, &new_permission)) {
     if (permission_set) {
-      NotifyPermissionSet(id,
-                          requesting_frame_origin,
-                          web_contents->GetLastCommittedURL().GetOrigin(),
-                          callback,
-                          true,
-                          new_permission);
+      NotifyPermissionSet(
+          id, requesting_frame_origin,
+          web_contents->GetLastCommittedURL().GetOrigin(), callback, true,
+          new_permission ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK);

[Michael van Ouwerkerk, 2015/02/26 15:09:49]

nit: the call to NotifyPermissionSet would be a bit more readable if you extract
this line to assign to a local variable first.

[mlamouri (slow - plz ping), 2015/02/26 21:19:38]

Done.

     }
     return;
   }
 
   PermissionContextBase::RequestPermission(web_contents, id,
                                            requesting_frame_origin,
                                            user_gesture,
                                            callback);
 }
 
@@ skipping 17 matching lines @@
                                       id.render_view_id());
   if (content_settings)
     content_settings->OnGeolocationPermissionSet(
         requesting_frame.GetOrigin(), allowed);
 
   if (allowed) {
     content::GeolocationProvider::GetInstance()
         ->UserDidOptIntoLocationServices();
   }
 }