chrome/browser/content_settings/permission_queue_controller.h - Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_queue_controller.h

Issue 955383003: ContentBrowserClient::RequestPermission replies with PermissionStatus instead of bool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_context_base_unittest.cc ('k') | chrome/browser/content_settings/permission_queue_controller.cc » ('j') | chrome/browser/geolocation/geolocation_permission_context.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_queue_controller.h

diff --git a/chrome/browser/content_settings/permission_queue_controller.h b/chrome/browser/content_settings/permission_queue_controller.h

index ba2dbd424e0d3fff393c9d11ca2103b7f61eb50f..1ea91f691b16366afe41644fc163b1ebcaccaeca 100644

--- a/chrome/browser/content_settings/permission_queue_controller.h

+++ b/chrome/browser/content_settings/permission_queue_controller.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_CONTENT_SETTINGS_PERMISSION_QUEUE_CONTROLLER_H_

#include "base/bind.h"

+#include "components/content_settings/core/common/content_settings.h"

#include "components/content_settings/core/common/content_settings_types.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

@@ -25,7 +26,7 @@ class Profile;

// the notification infrastructure would simplify.

class PermissionQueueController : public content::NotificationObserver {

public:

- typedef base::Callback<void(bool /* allowed */)> PermissionDecidedCallback;

+ using PermissionDecidedCallback = base::Callback<void(ContentSetting)>;

PermissionQueueController(Profile* profile, ContentSettingsType type);

~PermissionQueueController() override;