Issue 955313003: Files.app: Fix a bug in content hash computation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 955313003: Files.app: Fix a bug in content hash computation. (Closed)

Created:
5 years, 10 months ago by Steve McKay

Modified:
5 years, 10 months ago

Reviewers:
mtomasz

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Fix a bug in content hash computation. Break a circular reference which was causing FileManagerPrivateComputeChecksumFunction to never be cleaned up. This, in turn, was holding open one file stream for every file for which a content checksum was requested. BUG=458624 Review URL: https://codereview.chromium.org/950423003 Cr-Commit-Position: refs/heads/master@{#317997} (cherry picked from commit 78bb0f4b1c59602c67281bcbafb96eae90367040) TBR=mtomasz Committed: https://chromium.googlesource.com/chromium/src/+/16e89964e85ec54d0c3a6f81413764934be1a932

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
	M	chrome/browser/drive/drive_api_util.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	chrome/browser/drive/drive_api_util.cc	View		1 chunk	+16 lines, -14 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Steve McKay

5 years, 10 months ago (2015-02-26 23:18:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
16e89964e85ec54d0c3a6f81413764934be1a932 (presubmit successful).

Expand Messages | Collapse Messages