Files.app: Fix a bug in content hash computation.

Files.app: Fix a bug in content hash computation.

Break a circular reference which was causing FileManagerPrivateComputeChecksumFunction to never be cleaned up.  This, in turn, was holding open one file stream for every file for which a content checksum was requested.

BUG=458624
Committed: https://crrev.com/78bb0f4b1c59602c67281bcbafb96eae90367040
Cr-Commit-Position: refs/heads/master@{#317997}

[Ben Kwa, 2015-02-24 18:22:19]

kenobi@chromium.org changed reviewers:
+ mtomasz@chromium.org

[mtomasz, 2015-02-25 05:02:00]

lgtm with nit

https://codereview.chromium.org/950423003/diff/20001/chrome/browser/drive/dri...
File chrome/browser/drive/drive_api_util.h (right):

https://codereview.chromium.org/950423003/diff/20001/chrome/browser/drive/dri...
chrome/browser/drive/drive_api_util.h:97: void OnChunkRead(const ResultCallback&
callback, int bytesRead);
nit: bytes_read

[Ben Kwa, 2015-02-25 05:07:08]

Done.  Thanks!

https://codereview.chromium.org/950423003/diff/20001/chrome/browser/drive/dri...
File chrome/browser/drive/drive_api_util.h (right):

https://codereview.chromium.org/950423003/diff/20001/chrome/browser/drive/dri...
chrome/browser/drive/drive_api_util.h:97: void OnChunkRead(const ResultCallback&
callback, int bytesRead);
On 2015/02/25 05:02:00, mtomasz wrote:
> nit: bytes_read

Gah, missed the header. Done.

[Ben Kwa, 2015-02-25 05:07:27]

The CQ bit was checked by kenobi@chromium.org

[Ben Kwa, 2015-02-25 05:07:27]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/950423003/#ps40001 (title:
"Fix header file.")

[commit-bot: I haz the power, 2015-02-25 05:08:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950423003/40001

[commit-bot: I haz the power, 2015-02-25 06:24:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-25 06:25:14]

Patchset 3 (id:??) landed as
https://crrev.com/78bb0f4b1c59602c67281bcbafb96eae90367040
Cr-Commit-Position: refs/heads/master@{#317997}