Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 955313002: Files.app: Disable the cloud import notification for active g+ photos app users. (Closed)

Created:
5 years, 9 months ago by Ben Kwa
Modified:
5 years, 9 months ago
Reviewers:
mtomasz, Steve McKay
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, Steve McKay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Disable the cloud import notification for active g+ photos app users. If a user has auto-import enabled in the g+ photos app, don't enable cloud import, and don't pop up notifications for it yet. We'll re-enable these notifications when the transition path has been smoothed a bit more. BUG=462110 Committed: https://crrev.com/56c9dc7cb83ecb9fea6eeeefb2d7d401a3cda919 Cr-Commit-Position: refs/heads/master@{#318237}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback; fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -55 lines) Patch
M ui/file_manager/file_manager/background/js/device_handler.js View 1 1 chunk +5 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/background/js/device_handler_unittest.js View 1 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ben Kwa
5 years, 9 months ago (2015-02-26 05:36:40 UTC) #2
mtomasz
lgtm https://codereview.chromium.org/955313002/diff/1/ui/file_manager/file_manager/background/js/device_handler.js File ui/file_manager/file_manager/background/js/device_handler.js (right): https://codereview.chromium.org/955313002/diff/1/ui/file_manager/file_manager/background/js/device_handler.js#newcode489 ui/file_manager/file_manager/background/js/device_handler.js:489: // inserts a removable device. Only open files ...
5 years, 9 months ago (2015-02-26 05:40:34 UTC) #3
Steve McKay
lgtm
5 years, 9 months ago (2015-02-26 05:53:19 UTC) #5
Ben Kwa
Done. I had to remove the failing test because of the usual problem (no reliable ...
5 years, 9 months ago (2015-02-26 15:20:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955313002/20001
5 years, 9 months ago (2015-02-26 15:21:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 15:53:27 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 15:54:20 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56c9dc7cb83ecb9fea6eeeefb2d7d401a3cda919
Cr-Commit-Position: refs/heads/master@{#318237}

Powered by Google App Engine
This is Rietveld 408576698