Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: ui/file_manager/file_manager/background/js/device_handler.js

Issue 955313002: Files.app: Disable the cloud import notification for active g+ photos app users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback; fix tests. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/file_manager/background/js/device_handler_unittest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/background/js/device_handler.js
diff --git a/ui/file_manager/file_manager/background/js/device_handler.js b/ui/file_manager/file_manager/background/js/device_handler.js
index 5bd92016272ac5e92a0166a55d1bc5c6885ee14f..14bad6fb1b42918c15f0196e26f9dbd86a3eb755 100644
--- a/ui/file_manager/file_manager/background/js/device_handler.js
+++ b/ui/file_manager/file_manager/background/js/device_handler.js
@@ -485,19 +485,12 @@ DeviceHandler.prototype.onMount_ = function(event) {
* @this {DeviceHandler}
*/
function(appEnabled) {
- // We don't want to auto-open two windows
- // when a user inserts a removable device.
- // If Photos App is enabled only show a notification.
- if (appEnabled) {
- if (metadata.deviceType && metadata.devicePath) {
- DeviceHandler.Notification.DEVICE_IMPORT.show(
- /** @type {string} */ (
- metadata.devicePath));
- }
- } else {
+ // We don't want to auto-open two windows when a user
+ // inserts a removable device. Only open Files app if
+ // auto-import is disabled in Photos app.
+ if (!appEnabled) {
this.openMediaDirectory_(
- metadata.volumeId,
- directory.fullPath);
+ metadata.volumeId, directory.fullPath);
}
}.bind(this));
}.bind(this))
« no previous file with comments | « no previous file | ui/file_manager/file_manager/background/js/device_handler_unittest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698