Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 955303002: Web Animations: Remove AnimationPlayer discarding logic (Closed)

Created:
5 years, 10 months ago by Timothy Loh
Modified:
5 years, 9 months ago
Reviewers:
dstockwell, samli
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Remove AnimationPlayer discarding logic Since forwards filling animations are supposed to be returned via getAnimationPlayers, we can no longer discard them when we've dropped references to them. This patch removes this discarding logic. BUG=439247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191085

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : don't actually delete unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -115 lines) Patch
M Source/core/animation/Animation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/Animation.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationPlayer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/animation/AnimationPlayer.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/animation/AnimationStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimationStack.cpp View 2 chunks +0 lines, -27 lines 0 comments Download
M Source/core/animation/AnimationStackTest.cpp View 1 2 1 chunk +2 lines, -30 lines 0 comments Download
M Source/core/animation/SampledEffect.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/animation/SampledEffect.cpp View 1 2 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Timothy Loh
5 years, 10 months ago (2015-02-26 05:23:07 UTC) #2
Timothy Loh
Should work now
5 years, 10 months ago (2015-02-27 00:40:47 UTC) #3
samli
lgtm
5 years, 10 months ago (2015-02-27 00:53:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955303002/20001
5 years, 10 months ago (2015-02-27 02:22:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190977
5 years, 10 months ago (2015-02-27 05:01:44 UTC) #7
Mike West
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/967523002/ by mkwst@chromium.org. ...
5 years, 9 months ago (2015-02-27 10:46:11 UTC) #8
Timothy Loh
On 2015/02/27 10:46:11, Mike West wrote: > A revert of this CL (patchset #2 id:20001) ...
5 years, 9 months ago (2015-03-02 04:03:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955303002/40001
5 years, 9 months ago (2015-03-02 05:11:56 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 08:05:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191085

Powered by Google App Engine
This is Rietveld 408576698