Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: remoting/webapp/crd/js/oauth2_api_impl.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Requested changes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/oauth2_api_impl.js
diff --git a/remoting/webapp/crd/js/oauth2_api_impl.js b/remoting/webapp/crd/js/oauth2_api_impl.js
index 18a71ce03d8e478d412e4430a63939eab7f468dc..1b86d9b2249e1f7fe5371fc5e17c2b7ffcdf60a5 100644
--- a/remoting/webapp/crd/js/oauth2_api_impl.js
+++ b/remoting/webapp/crd/js/oauth2_api_impl.js
@@ -39,13 +39,13 @@ remoting.OAuth2ApiImpl.prototype.getOAuth2ApiUserInfoEndpoint_ = function() {
*
* @private
* @param {number} xhrStatus Status (HTTP response code) of the XMLHttpRequest.
- * @return {remoting.Error} An error code to be raised.
+ * @return {!remoting.Error} An error code to be raised.
*/
remoting.OAuth2ApiImpl.prototype.interpretXhrStatus_ =
function(xhrStatus) {
// Return AUTHENTICATION_FAILED by default, so that the user can try to
// recover from an unexpected failure by signing in again.
- /** @type {remoting.Error} */
+ /** @type {!remoting.Error} */
var error = remoting.Error.AUTHENTICATION_FAILED;
if (xhrStatus == 400 || xhrStatus == 401 || xhrStatus == 403) {
error = remoting.Error.AUTHENTICATION_FAILED;
@@ -64,7 +64,7 @@ remoting.OAuth2ApiImpl.prototype.interpretXhrStatus_ =
*
* @param {function(string, number): void} onDone Callback to invoke when
* the access token and expiration time are successfully fetched.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} clientId OAuth2 client ID.
* @param {string} clientSecret OAuth2 client secret.
@@ -112,7 +112,7 @@ remoting.OAuth2ApiImpl.prototype.refreshAccessToken = function(
* @param {function(string, string, number): void} onDone Callback to
* invoke when the refresh token, access token and access token expiration
* time are successfully fetched.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} clientId OAuth2 client ID.
* @param {string} clientSecret OAuth2 client secret.
@@ -162,7 +162,7 @@ remoting.OAuth2ApiImpl.prototype.exchangeCodeForTokens = function(
*
* @param {function(string):void} onDone Callback invoked when the email
* address is available.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} token Access token.
* @return {void} Nothing.
@@ -197,7 +197,7 @@ remoting.OAuth2ApiImpl.prototype.getEmail = function(onDone, onError, token) {
*
* @param {function(string, string):void} onDone Callback invoked when the email
* address and full name are available.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} token Access token.
* @return {void} Nothing.

Powered by Google App Engine
This is Rietveld 408576698