Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: remoting/webapp/crd/js/oauth2_api.js

Issue 955283002: Converted remoting.Error from an enum to a class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Requested changes. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/oauth2_api.js
diff --git a/remoting/webapp/crd/js/oauth2_api.js b/remoting/webapp/crd/js/oauth2_api.js
index 7e5173f3eb4312dd3999881a0d545c5aea4ddafa..4c58a1671d3c5064023770975ee7922c87f6c595 100644
--- a/remoting/webapp/crd/js/oauth2_api.js
+++ b/remoting/webapp/crd/js/oauth2_api.js
@@ -21,7 +21,7 @@ remoting.OAuth2Api = function() {
*
* @param {function(string, number): void} onDone Callback to invoke when
* the access token and expiration time are successfully fetched.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} clientId OAuth2 client ID.
* @param {string} clientSecret OAuth2 client secret.
@@ -38,7 +38,7 @@ remoting.OAuth2Api.prototype.refreshAccessToken = function(
* @param {function(string, string, number): void} onDone Callback to
* invoke when the refresh token, access token and access token expiration
* time are successfully fetched.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} clientId OAuth2 client ID.
* @param {string} clientSecret OAuth2 client secret.
@@ -59,7 +59,7 @@ remoting.OAuth2Api.prototype.exchangeCodeForTokens = function(
*
* @param {function(string):void} onDone Callback invoked when the email
* address is available.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} token Access token.
* @return {void} Nothing.
@@ -72,7 +72,7 @@ remoting.OAuth2Api.prototype.getEmail = function(onDone, onError, token) {
*
* @param {function(string, string):void} onDone Callback invoked when the email
* address and full name are available.
- * @param {function(remoting.Error):void} onError Callback invoked if an
+ * @param {function(!remoting.Error):void} onError Callback invoked if an
* error occurs.
* @param {string} token Access token.
* @return {void} Nothing.

Powered by Google App Engine
This is Rietveld 408576698