Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 955263003: Telemetry: Simplify exception handling of failed websocket connections. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Simplify exception handling of failed websocket connections. Previously, an intermediary exception InspectorException was generated. This was caught and then converted into a more common Telemetry exception. Now the connection failure throws a standard Telemetry exception directly. BUG=460625 Committed: https://crrev.com/b18d23f7330a6d01dd7dda7f5bc4713fdc470afe Cr-Commit-Position: refs/heads/master@{#319161}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py View 1 1 chunk +6 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 2 chunks +1 line, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
erikchen
nednguyen: Please review.
5 years, 9 months ago (2015-02-28 00:56:46 UTC) #2
nednguyen
5 years, 9 months ago (2015-03-04 00:20:22 UTC) #4
sullivan
lgtm
5 years, 9 months ago (2015-03-04 14:38:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955263003/20001
5 years, 9 months ago (2015-03-04 22:17:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 23:22:53 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 23:23:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b18d23f7330a6d01dd7dda7f5bc4713fdc470afe
Cr-Commit-Position: refs/heads/master@{#319161}

Powered by Google App Engine
This is Rietveld 408576698