tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py - Issue 955263003: Telemetry: Simplify exception handling of failed websocket connections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 955263003: Telemetry: Simplify exception handling of failed websocket connections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions5

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend_list.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

index 51591e4f8a0210cc6aea411a9969288904821b06..5d487cd336c8e55b6b200b0e9f6d7549b46ba827 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

@@ -23,10 +23,6 @@ from telemetry.timeline import model as timeline_model_module

from telemetry.timeline import trace_data as trace_data_module

-class InspectorException(Exception):

- pass

class InspectorBackend(object):

def __init__(self, app, devtools_client, context, timeout=60):

self._websocket = inspector_websocket.InspectorWebsocket()

@@ -45,7 +41,7 @@ class InspectorBackend(object):

try:

self._websocket.Connect(self.debugger_url)

except (websocket.WebSocketException, exceptions.TimeoutException) as e:

- raise InspectorException(e.msg)

+ self._HandleError(e)

self._console = inspector_console.InspectorConsole(self._websocket)

self._memory = inspector_memory.InspectorMemory(self._websocket)