Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 955183003: Revert of [Telemetry] Pass test_runner environment in local args instead of a global variable (Closed)

Created:
5 years, 10 months ago by eakuefner
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Pass test_runner environment in local args instead of a global variable (patchset #9 id:160001 of https://codereview.chromium.org/942663002/) Reason for revert: crbug.com/462063 Original issue's description: > [Telemetry] Pass test_runner environment in local args instead of a global variable > > Also adds more fields to environment to narrow the scope of > benchmark and user story set discovery. This should avoid problems > with adding Python files to unrelated directories, and hides PageTests > from external Telemetry benchmark runners like run_gpu_tests.py and > chrome_proxy's run_benchmark. > > R=dtu,nednguyen,sullivan,kbr@chromium.org,bolian > BUG=460181 > TEST=tools/perf/run_benchmark; content/test/gpu/run_gpu_tests.py; tools/chrome_proxy/run_benchmark # All return a full and correct test list. > > Committed: https://crrev.com/1da5f7f70ea6dc7dd0667ea78637802c76305f5a > Cr-Commit-Position: refs/heads/master@{#318149} TBR=bolian@chromium.org,dtu@chromium.org,kbr@chromium.org,nednguyen@google.com,sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460181 Committed: https://crrev.com/f29d78349447bc24719a98a80f1d90ae1f431952 Cr-Commit-Position: refs/heads/master@{#318175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -88 lines) Patch
M content/test/gpu/run_gpu_test.py View 2 chunks +4 lines, -5 lines 0 comments Download
M tools/chrome_proxy/run_benchmark View 1 chunk +4 lines, -5 lines 0 comments Download
M tools/perf/run_benchmark View 1 chunk +4 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner.py View 8 chunks +25 lines, -56 lines 0 comments Download
M tools/telemetry/telemetry/core/command_line.py View 1 chunk +0 lines, -10 lines 0 comments Download
A tools/telemetry/telemetry/core/environment.py View 1 chunk +20 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/util/find_dependencies.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
eakuefner
Created Revert of [Telemetry] Pass test_runner environment in local args instead of a global variable
5 years, 10 months ago (2015-02-26 02:37:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955183003/1
5 years, 10 months ago (2015-02-26 02:38:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-26 02:38:32 UTC) #4
sullivan
lgtm
5 years, 10 months ago (2015-02-26 02:46:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955183003/1
5 years, 10 months ago (2015-02-26 02:50:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 02:51:46 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 02:52:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f29d78349447bc24719a98a80f1d90ae1f431952
Cr-Commit-Position: refs/heads/master@{#318175}

Powered by Google App Engine
This is Rietveld 408576698