Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/telemetry/telemetry/unittest_util/run_tests.py

Issue 955183003: Revert of [Telemetry] Pass test_runner environment in local args instead of a global variable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/environment.py ('k') | tools/telemetry/telemetry/util/find_dependencies.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/unittest_util/run_tests.py
diff --git a/tools/telemetry/telemetry/unittest_util/run_tests.py b/tools/telemetry/telemetry/unittest_util/run_tests.py
index 8539e5d341ea5ce7f753d592d421ef2778268899..0d44f218d42d917434d352ee6e9513edfa8de9c9 100644
--- a/tools/telemetry/telemetry/unittest_util/run_tests.py
+++ b/tools/telemetry/telemetry/unittest_util/run_tests.py
@@ -35,7 +35,7 @@
return parser
@classmethod
- def AddCommandLineArgs(cls, parser, _):
+ def AddCommandLineArgs(cls, parser):
parser.add_option('--repeat-count', type='int', default=1,
help='Repeats each a provided number of times.')
parser.add_option('-d', '--also-run-disabled-tests',
@@ -55,7 +55,7 @@
reporting=True)
@classmethod
- def ProcessCommandLineArgs(cls, parser, args, _):
+ def ProcessCommandLineArgs(cls, parser, args):
# We retry failures by default unless we're running a list of tests
# explicitly.
if not args.retry_limit and not args.positional_args:
@@ -75,10 +75,10 @@
def main(cls, args=None, stream=None): # pylint: disable=W0221
# We override the superclass so that we can hook in the 'stream' arg.
parser = cls.CreateParser()
- cls.AddCommandLineArgs(parser, None)
+ cls.AddCommandLineArgs(parser)
options, positional_args = parser.parse_args(args)
options.positional_args = positional_args
- cls.ProcessCommandLineArgs(parser, options, None)
+ cls.ProcessCommandLineArgs(parser, options)
obj = cls()
if stream is not None:
« no previous file with comments | « tools/telemetry/telemetry/core/environment.py ('k') | tools/telemetry/telemetry/util/find_dependencies.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698