Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 955063002: Fix memory leak caused by field type in descriptor array. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix memory leak caused by field type in descriptor array. When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. Map::GetFieldType(i) does the unwrapping. BUG=v8:3877 LOG=N TEST=cctest/test-heap/Regress3877 Committed: https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e Cr-Commit-Position: refs/heads/master@{#26879}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove unused var in release. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -28 lines) Patch
M src/objects.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 8 chunks +43 lines, -20 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/property.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M test/cctest/test-migrations.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
ulan
PTAL
5 years, 10 months ago (2015-02-26 09:46:22 UTC) #2
Toon Verwaest
Looks good, but what about getting rid of using HeapType altogether for the field type?
5 years, 10 months ago (2015-02-26 10:00:28 UTC) #3
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-26 10:49:41 UTC) #4
ulan
On 2015/02/26 10:49:41, Toon Verwaest wrote: > lgtm Thanks, landing. > Looks good, but what ...
5 years, 10 months ago (2015-02-26 10:54:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955063002/20001
5 years, 10 months ago (2015-02-26 10:56:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/289)
5 years, 10 months ago (2015-02-26 10:59:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/955063002/40001
5 years, 10 months ago (2015-02-26 12:54:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-26 13:16:38 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e Cr-Commit-Position: refs/heads/master@{#26879}
5 years, 10 months ago (2015-02-26 13:16:49 UTC) #14
marja
5 years, 10 months ago (2015-02-26 14:45:24 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/960103003/ by marja@chromium.org.

The reason for reverting is: Breaks test/mjsunit/debug-clearbreakpointgroup.js
on arm64.debug..

Powered by Google App Engine
This is Rietveld 408576698