Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: test/cctest/test-migrations.cc

Issue 955063002: Fix memory leak caused by field type in descriptor array. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove unused var in release. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-migrations.cc
diff --git a/test/cctest/test-migrations.cc b/test/cctest/test-migrations.cc
index 9eb367639a647da1592873dc6ea569cf4c831948..c7aaf29d6643e420254aeefa6d4df871ed6ca99e 100644
--- a/test/cctest/test-migrations.cc
+++ b/test/cctest/test-migrations.cc
@@ -233,12 +233,14 @@ class Expectations {
representations_[descriptor])) {
return false;
}
- Object* expected_value = *values_[descriptor];
Object* value = descriptors->GetValue(descriptor);
+ Object* expected_value = *values_[descriptor];
switch (type) {
case DATA:
- case ACCESSOR:
- return HeapType::cast(expected_value)->Equals(HeapType::cast(value));
+ case ACCESSOR: {
+ HeapType* type = descriptors->GetFieldType(descriptor);
+ return HeapType::cast(expected_value)->Equals(type);
+ }
case DATA_CONSTANT:
return value == expected_value;
« no previous file with comments | « test/cctest/test-heap.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698